lib: prefer Atomics primordials #58577
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
ljharb
approved these changes
Jun 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58577 +/- ##
==========================================
- Coverage 90.21% 90.19% -0.02%
==========================================
Files 635 635
Lines 187494 187488 -6
Branches 36838 36817 -21
==========================================
- Hits 169144 169109 -35
- Misses 11145 11164 +19
- Partials 7205 7215 +10
🚀 New features to boost your workflow:
|
targos
approved these changes
Jun 4, 2025
|
Can you make it two PRs? That would help with backporting (the subsystem should probably be |
jazelly
approved these changes
Jun 5, 2025
marco-ippolito
approved these changes
Jun 5, 2025
atlowChemi
approved these changes
Jun 5, 2025
JakobJingleheimer
approved these changes
Jun 5, 2025
aduh95
pushed a commit
that referenced
this pull request
Jun 15, 2025
PR-URL: #58577 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58577 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
This was referenced Jun 23, 2025
aduh95
pushed a commit
that referenced
this pull request
Jul 28, 2025
PR-URL: #58577 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typings: add Atomics primordials
Note that
Atomics.pause()is still flagged.lib: prefer Atomics primordials
The majority of cases already use primordials, but there are a couple of hangovers.